Not to Egypt, but to other Arab countries, but I guess generally the same applies to Egypt (besides local laws of course).
- landscapes, those are great depending on where you go, so prepare for that (sunrise/set over the Nile, the desert...)
- I do not differnciate between general tourism and photography trips, but that is just me
- architecture, from details to the big picture, you will be surpised how many great images can be taken even at the most famous and photographed locations
- ask people before taking pictures of them, showing them the camera usually is enough (I don't take pictures of people, other people I know do without problems as long as you ask)
- I could imagine that there is some wildlife along the Nile, so something longer but not a 800mm prime woupd be a good thing, this also helps with detailed landscape and architecture images
- never ever take images of police, military nor their buildings or installations, they don't like that there, and they look
- unless they ask you too, happens sometimes for some reason
I wouldn't go without my gear to Egypt, I'd regret it forever. That would mean two bodies (one for me, a DX one as backup and for family), a short lense, something like a 24-120 and something longer (around 300 or so, or a zoom covering that). Whether or not I'd take a Macro lense would depend on space, but propably yes.
That being said, I went to Tunesia with a D700, 18-35 (?) and a 24-120 and didn't really miss anything. That was before I started taking landscapes with longer lenses so.